Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: apollo data change listener #670

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Jul 21, 2020

What this PR does:

  • update apollo client
  • fix data change listener problem

@AlexStocks AlexStocks requested review from xujianhai666 and fangyincheng and removed request for xujianhai666 July 21, 2020 23:27
@AlexStocks
Copy link
Contributor

Pls merge the latest develop branch codes to fix the travis failure.

@codecov-commenter
Copy link

Codecov Report

Merging #670 into 1.4 will decrease coverage by 0.29%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.4     #670      +/-   ##
==========================================
- Coverage   67.11%   66.81%   -0.30%     
==========================================
  Files         174      174              
  Lines        9259     9257       -2     
==========================================
- Hits         6214     6185      -29     
- Misses       2434     2460      +26     
- Partials      611      612       +1     
Impacted Files Coverage Δ
config_center/apollo/listener.go 82.60% <73.33%> (-17.40%) ⬇️
config_center/apollo/impl.go 85.50% <100.00%> (-1.51%) ⬇️
config_center/nacos/facade.go 37.50% <0.00%> (-34.38%) ⬇️
remoting/kubernetes/listener.go 56.07% <0.00%> (-6.55%) ⬇️
config_center/nacos/client.go 65.74% <0.00%> (-1.86%) ⬇️
protocol/dubbo/client.go 67.87% <0.00%> (-1.22%) ⬇️
remoting/kubernetes/watch.go 78.30% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428fe1a...491edb6. Read the comment docs.

@AlexStocks AlexStocks merged commit 0686ca9 into apache:1.4 Jul 30, 2020
@zouyx zouyx deleted the hotfix/fix1.4 branch August 2, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants