Mod: Remove unnecessary return and judgement. #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Aug 27, 2020
zouyx
reviewed
Aug 28, 2020
There was a problem hiding this comment.
I think more improve as below
- change target branch to
develop - fix travis
- change PR title, base on https://github.com/apache/dubbo-go/blob/master/contributing.md
atlas-comstock
changed the title
atlas-comstock
force-pushed
the
remove-unnecessary-statement
branch
from
b327fd2 to
e1a0284
Compare
|
@zouyx hi, about the |
Maybe......... |
zouyx
reviewed
Aug 29, 2020
atlas-comstock
force-pushed
the
remove-unnecessary-statement
branch
from
e1a0284 to
255317c
Compare
atlas-comstock
force-pushed
the
remove-unnecessary-statement
branch
from
255317c to
7e4e7fd
Compare
zouyx
approved these changes
Aug 29, 2020
AlexStocks
approved these changes
Aug 29, 2020
zouyx
added
enhancement
gaoxinge
approved these changes
Aug 31, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
…ment Mod: Remove unnecessary return and judgement. # Conflicts: # cluster/router/tag/tag_router.go
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Mod: Remove unnecessary return and judgement. # Conflicts: # cluster/router/tag/tag_router.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Sharp the code.
Which issue(s) this PR fixes: Readable code.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: