Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: go get fail #793

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Fix: go get fail #793

merged 3 commits into from
Oct 15, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Oct 15, 2020

What this PR does:

  • Fix go get fail and release a new version which is called v1.5.3

Which issue(s) this PR fixes:

Fixes #789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #793 into 1.5 will decrease coverage by 3.96%.
The diff coverage is 52.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5     #793      +/-   ##
==========================================
- Coverage   63.72%   59.76%   -3.97%     
==========================================
  Files         237      258      +21     
  Lines       12295    12585     +290     
==========================================
- Hits         7835     7521     -314     
- Misses       3706     4120     +414     
- Partials      754      944     +190     
Impacted Files Coverage Δ
cluster/loadbalance/consistent_hash.go 87.75% <ø> (-2.57%) ⬇️
cluster/router/condition/listenable_router.go 54.71% <ø> (-0.13%) ⬇️
cluster/router/tag/file.go 76.19% <ø> (-0.74%) ⬇️
common/extension/health_checker.go 50.00% <ø> (-16.67%) ⬇️
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/logger/logger.go 91.37% <0.00%> (-3.86%) ⬇️
common/proxy/proxy_factory/default.go 13.33% <0.00%> (-7.31%) ⬇️
common/rpc_service.go 87.94% <ø> (+1.35%) ⬆️
common/yaml/yaml.go 90.90% <0.00%> (-9.10%) ⬇️
config/provider_config.go 50.00% <0.00%> (-8.07%) ⬇️
... and 346 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1d1e5...d25bb8f. Read the comment docs.

@fangyincheng fangyincheng merged commit 1268a96 into apache:1.5 Oct 15, 2020
@zouyx zouyx deleted the fixGoGetFail branch October 31, 2020 16:24
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants