Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Consumer panic when restart provider #803

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Oct 25, 2020

What this PR does:

However ExchangeClient.init is false cause getty_pool will not re-init when re-request.

Then getty_pool is nil when re-request, detail as below

image

Solution:

  • Change a flag for re-init getty_pool

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added the bug Something isn't working label Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #803 into 1.5 will decrease coverage by 4.16%.
The diff coverage is 52.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5     #803      +/-   ##
==========================================
- Coverage   63.72%   59.56%   -4.17%     
==========================================
  Files         237      258      +21     
  Lines       12295    12585     +290     
==========================================
- Hits         7835     7496     -339     
- Misses       3706     4142     +436     
- Partials      754      947     +193     
Impacted Files Coverage Δ
cluster/loadbalance/consistent_hash.go 87.75% <ø> (-2.57%) ⬇️
cluster/router/condition/listenable_router.go 54.71% <ø> (-0.13%) ⬇️
cluster/router/tag/file.go 76.19% <ø> (-0.74%) ⬇️
common/extension/health_checker.go 50.00% <ø> (-16.67%) ⬇️
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/logger/logger.go 91.37% <0.00%> (-3.86%) ⬇️
common/proxy/proxy_factory/default.go 13.33% <0.00%> (-7.31%) ⬇️
common/rpc_service.go 87.94% <ø> (+1.35%) ⬆️
common/yaml/yaml.go 90.90% <0.00%> (-9.10%) ⬇️
config/provider_config.go 50.00% <0.00%> (-8.07%) ⬇️
... and 346 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1268a96...643a7c7. Read the comment docs.

@watermelo watermelo self-requested a review October 25, 2020 16:58
@zouyx zouyx linked an issue Oct 26, 2020 that may be closed by this pull request
@xibolun
Copy link
Contributor

xibolun commented Oct 28, 2020

测试成功

@AlexStocks AlexStocks merged commit e6a3382 into apache:1.5 Oct 28, 2020
@zouyx zouyx added this to the v1.5.4 milestone Oct 30, 2020
zouyx pushed a commit that referenced this pull request Oct 31, 2020
Fix: Consumer panic when restart provider
@zouyx zouyx deleted the fixRestartBug branch October 31, 2020 16:24
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Fix: Consumer panic when restart provider
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Fix: Consumer panic when restart provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider 重启之后 consumer 无法重连
7 participants