-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Consumer panic when restart provider #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.5 #803 +/- ##
==========================================
- Coverage 63.72% 59.56% -4.17%
==========================================
Files 237 258 +21
Lines 12295 12585 +290
==========================================
- Hits 7835 7496 -339
- Misses 3706 4142 +436
- Partials 754 947 +193
Continue to review full report at Codecov.
|
watermelo
approved these changes
Oct 25, 2020
AlexStocks
approved these changes
Oct 26, 2020
测试成功 |
Patrick0308
approved these changes
Oct 28, 2020
zouyx
pushed a commit
that referenced
this pull request
Oct 31, 2020
Fix: Consumer panic when restart provider
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Fix: Consumer panic when restart provider
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Fix: Consumer panic when restart provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When delete provider node will close getty_client and set getty_pool to nil.
dubbo-go/remoting/exchange_client.go
Line 182 in 1268a96
However ExchangeClient.init is false cause getty_pool will not re-init when re-request.
dubbo-go/remoting/exchange_client.go
Line 61 in 1268a96
Then getty_pool is nil when re-request, detail as below
Solution:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: