Ftr: Add grpc max message size config #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
xujianhai666,
cvictory and
zouyx
and removed request for
xujianhai666 and
cvictory
AlexStocks
reviewed
Oct 30, 2020
| @@ -18,6 +18,8 @@ | |||
| package grpc | |||
|
|
|||
| import ( | |||
AlexStocks
approved these changes
Oct 30, 2020
hxmhlt
approved these changes
Nov 3, 2020
AlexStocks
approved these changes
Nov 3, 2020
cityiron
reviewed
Nov 6, 2020
common/constant/key.go
Outdated
| @@ -25,6 +25,7 @@ const ( | |||
| GROUP_KEY = "group" | |||
| VERSION_KEY = "version" | |||
| INTERFACE_KEY = "interface" | |||
| GRPC_MESSAGE_SIZE_KEY = "message_size" | |||
There was a problem hiding this comment.
GRPC_MESSAGE_SIZE_KEY change to MESSAGE_SIZE_KEY may be better.
|
LGTM |
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Ftr: Add grpc max message size config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
增加“在配置文件中设置grpc max message size“”的功能。
Which issue(s) this PR fixes:
Fixes #806
Special notes for your reviewer:
在Service中增加标签为 max_message_size的字段，在开启grpc server时作为参数传入，并写入invoker用于暴露。
客户端拿到服务端url后会更新本地invoker，grpc client会自动调整为与服务端message_size一致。
Does this PR introduce a user-facing change?:
NONE