[Fix] struct javaclassname 2 dubbo provider #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When dubbogo(develop branch) call dubbo(2.7.7), if params is struct, will error:
2020-12-02T18:29:34.332+0800 ERROR dubbo/dubbo_codec.go:249 pkg.Unmarshal(len(@data):0) = error:java exception:Fail to decode request due to: java.lang.IllegalArgumentException: Service not found:com.funnycode.DemoService, sayHello java.lang.IllegalArgumentException: Service not found:com.funnycode.DemoService, sayHello at org.apache.dubbo.rpc.protocol.dubbo.DecodeableRpcInvocation.decode(DecodeableRpcInvocation.java:134) at org.apache.dubbo.rpc.protocol.dubbo.DecodeableRpcInvocation.decode(DecodeableRpcInvocation.java:80) at org.apache.dubbo.remoting.transport.DecodeHandler.decode(DecodeHandler.java:57) at org.apache.dubbo.remoting.transport.DecodeHandler.received(DecodeHandler.java:44) at org.apache.dubbo.remoting.transport.dispatcher.ChannelEventRunnable.run(ChannelEventRunnable.java:57) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)
This happen at :
I change to dubbo 2.7.3, will error too. follow is the output:
I found this is not found method cause by method params, because dubbogo set params type
java.lang.Object
.I testing for dubbogo 2 dubbogo, dubbogo 2 dubbo(2.7.3,2.7.7) ,dubbo from develop branch can invoke successful.
Which issue(s) this PR fixes:
Fixes #900
Special notes for your reviewer:
Does this PR introduce a user-facing change?: