Optimize the memory usage #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
- Coverage 59.85% 59.82% -0.04%
===========================================
Files 260 260
Lines 12854 12858 +4
===========================================
- Hits 7694 7692 -2
- Misses 4199 4202 +3
- Partials 961 964 +3
Continue to review full report at Codecov.
|
common/url.go
Outdated
| @@ -427,6 +427,17 @@ func (c *URL) SetParam(key string, value string) { | |||
| c.params.Set(key, value) | |||
| } | |||
|
|
|||
| // SetParams will replace the URL.params | |||
| // SetParams will put all key-value pair into url. | |||
There was a problem hiding this comment.
This comment and function not match?
|
LGTM |
hxmhlt
approved these changes
Dec 14, 2020
cityiron
approved these changes
Dec 18, 2020
Patrick0308
approved these changes
Dec 18, 2020
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
* #901 Optimize the memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Optimize some memory usage issue , please refer to #901
In this way, we can remove some lock for it is cloned in MergeURL
Which issue(s) this PR fixes:
Fixes #901
Special notes for your reviewer:
Does this PR introduce a user-facing change?: