Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generic_filter): struct2MapAll key of map keep type of int f… #928

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

ljun20160606
Copy link

…loat string

What this PR does:

Which issue(s) this PR fixes:

Fixes #865

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #928 (e3c5cf3) into develop (1156b92) will increase coverage by 0.14%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #928      +/-   ##
===========================================
+ Coverage    59.83%   59.97%   +0.14%     
===========================================
  Files          260      260              
  Lines        12854    12861       +7     
===========================================
+ Hits          7691     7714      +23     
+ Misses        4202     4184      -18     
- Partials       961      963       +2     
Impacted Files Coverage Δ
filter/filter_impl/generic_filter.go 71.21% <75.00%> (-0.92%) ⬇️
metadata/definition/mock.go 0.00% <0.00%> (-25.00%) ⬇️
remoting/getty/pool.go 68.72% <0.00%> (-0.89%) ⬇️
protocol/grpc/grpc_exporter.go 100.00% <0.00%> (ø)
protocol/rest/rest_exporter.go 100.00% <0.00%> (ø)
protocol/dubbo/dubbo_exporter.go 100.00% <0.00%> (ø)
protocol/jsonrpc/jsonrpc_exporter.go 100.00% <0.00%> (ø)
filter/filter_impl/generic_service_filter.go 67.30% <0.00%> (ø)
cluster/router/healthcheck/default_health_check.go 94.11% <0.00%> (ø)
common/rpc_service.go 88.11% <0.00%> (+0.16%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1156b92...e3c5cf3. Read the comment docs.

@cityiron
Copy link
Contributor

pls change your target branch to develop.

@ljun20160606 ljun20160606 changed the base branch from master to develop December 14, 2020 04:18
@ljun20160606
Copy link
Author

pls change your target branch to develop.

Done

@ljun20160606 ljun20160606 requested a review from hxmhlt December 18, 2020 05:46
@zouyx zouyx added the improve Refactor or improve label Dec 20, 2020
@zouyx zouyx added this to the v1.5.6 milestone Dec 20, 2020
@AlexStocks AlexStocks merged commit 9449801 into apache:develop Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

泛化调用hessian解析map[int]int的问题
8 participants