Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a export flag to decide if a service should be export #955

Merged
merged 3 commits into from
Dec 24, 2020
Merged

introduce a export flag to decide if a service should be export #955

merged 3 commits into from
Dec 24, 2020

Conversation

beiwei30
Copy link
Member

it is particularly useful with a config-post-processor

What this PR does:

Introduce a export flag to align with java implementation. It is particularly useful when a config post processor decides to break the exporting process.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


it is particularly useful with a config-post-processor
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #955 (59d4e4e) into develop (f8c8593) will decrease coverage by 0.20%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #955      +/-   ##
===========================================
- Coverage    60.27%   60.07%   -0.21%     
===========================================
  Files          261      261              
  Lines        12905    12910       +5     
===========================================
- Hits          7779     7756      -23     
- Misses        4160     4199      +39     
+ Partials       966      955      -11     
Impacted Files Coverage Δ
config/service_config.go 55.03% <80.00%> (-7.47%) ⬇️
config/config_loader.go 40.95% <0.00%> (-12.77%) ⬇️
remoting/getty/listener.go 41.62% <0.00%> (+0.54%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.31% <0.00%> (+2.40%) ⬆️
remoting/getty/pool.go 71.36% <0.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c8593...59d4e4e. Read the comment docs.

@beiwei30
Copy link
Member Author

merge the develop to solve the conflict.

@Patrick0308 Patrick0308 merged commit ed97c95 into apache:develop Dec 24, 2020
@beiwei30 beiwei30 deleted the export-flag branch December 25, 2020 10:24
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
introduce a export flag to decide if a service should be export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants