Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance overhead caused by too much unknown classloading during hessian2 deserialization #7

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

hopelove404
Copy link

@hopelove404 hopelove404 commented Jan 30, 2019

What is the purpose of the change

To avoid frequently class loading and to reduce performance overhead during the process of hessian2 deserialization for those classes are unknown in current classloader

Brief changelog

com.alibaba.com.caucho.hessian.io.SerializerFactory#getDeserializer(String type)

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #7 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
+ Coverage     24.16%   24.24%   +0.08%     
- Complexity      453      455       +2     
============================================
  Files            89       89              
  Lines          6287     6289       +2     
  Branches       1048     1048              
============================================
+ Hits           1519     1525       +6     
+ Misses         4550     4547       -3     
+ Partials        218      217       -1
Impacted Files Coverage Δ Complexity Δ
...ibaba/com/caucho/hessian/io/SerializerFactory.java 66.78% <100%> (+1.65%) 54 <9> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7dd9bf...2052f96. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented Feb 2, 2019

merged. I will follow up with 'import star'.

@hopelove404
Copy link
Author

@beiwei30 Thanks for help remove'import star'.

@hopelove404 hopelove404 deleted the hessian-optimize-typenotfound branch February 2, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants