Skip to content

Commit

Permalink
fix fastjson serialization with generic return type (#3771)
Browse files Browse the repository at this point in the history
  • Loading branch information
cyejing authored and kexianjun committed Apr 1, 2019
1 parent 90ffbc2 commit 3b145c7
Show file tree
Hide file tree
Showing 3 changed files with 78 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package org.apache.dubbo.common.serialize.fastjson;

import org.apache.dubbo.common.serialize.ObjectInput;
import org.apache.dubbo.common.utils.PojoUtils;

import com.alibaba.fastjson.JSON;

Expand Down Expand Up @@ -103,8 +102,8 @@ public <T> T readObject(Class<T> cls) throws IOException, ClassNotFoundException
@Override
@SuppressWarnings("unchecked")
public <T> T readObject(Class<T> cls, Type type) throws IOException, ClassNotFoundException {
Object value = readObject(cls);
return (T) PojoUtils.realize(value, cls, type);
String json = readLine();
return (T) JSON.parseObject(json, type);
}

private String readLine() throws IOException, EOFException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@

import com.alibaba.fastjson.JSONObject;

import java.lang.reflect.Method;
import java.lang.reflect.Type;
import java.util.List;
import org.apache.dubbo.common.serialize.model.Organization;
import org.apache.dubbo.common.serialize.model.Person;

import org.junit.jupiter.api.Assertions;
Expand All @@ -32,6 +36,7 @@
import static org.hamcrest.CoreMatchers.nullValue;
import static org.hamcrest.core.Is.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class FastJsonObjectInputTest {
private FastJsonObjectInput fastJsonObjectInput;
Expand Down Expand Up @@ -151,4 +156,44 @@ public void testReadObjectWithoutClass() throws IOException, ClassNotFoundExcept
assertThat(readObject.getString("name"), is("John"));
assertThat(readObject.getInteger("age"), is(30));
}
}


@Test
public void testReadObjectWithTowType() throws Exception {
fastJsonObjectInput = new FastJsonObjectInput(new StringReader("[{\"name\":\"John\",\"age\":30},{\"name\":\"Born\",\"age\":24}]"));

Method methodReturnType = getClass().getMethod("towLayer");
Type type = methodReturnType.getGenericReturnType();
List<Person> o = fastJsonObjectInput.readObject(List.class, type);

assertTrue(o instanceof List);
assertTrue(o.get(0) instanceof Person);

assertThat(o.size(), is(2));
assertThat(o.get(1).getName(), is("Born"));
}

@Test
public void testReadObjectWithThreeType() throws Exception {
fastJsonObjectInput = new FastJsonObjectInput(new StringReader("{\"data\":[{\"name\":\"John\",\"age\":30},{\"name\":\"Born\",\"age\":24}]}"));

Method methodReturnType = getClass().getMethod("threeLayer");
Type type = methodReturnType.getGenericReturnType();
Organization<List<Person>> o = fastJsonObjectInput.readObject(Organization.class, type);

assertTrue(o instanceof Organization);
assertTrue(o.getData() instanceof List);
assertTrue(o.getData().get(0) instanceof Person);

assertThat(o.getData().size(), is(2));
assertThat(o.getData().get(1).getName(), is("Born"));
}

public List<Person> towLayer() {
return null;
}

public Organization<List<Person>> threeLayer() {
return null;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dubbo.common.serialize.model;

public class Organization<T> {

private T data;

public T getData() {
return data;
}

public void setData(T data) {
this.data = data;
}
}

0 comments on commit 3b145c7

Please sign in to comment.