Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Dubbo Error Code Inspector 'really' works. #11127

Closed
1 task done
win120a opened this issue Dec 13, 2022 · 0 comments · Fixed by #11182
Closed
1 task done

Make the Dubbo Error Code Inspector 'really' works. #11127

win120a opened this issue Dec 13, 2022 · 0 comments · Fixed by #11182
Labels
type/proposal Everything you want Dubbo have

Comments

@win120a
Copy link
Contributor

win120a commented Dec 13, 2022

  • I have searched the issues of this repository and believe that this is not a duplicate.

It has been a long time that the Apache Dubbo Error Code Inspector works in tolorence mode due to historical reasons. Hence, the error-code-inspecting GitHub workflow always passes the test regardless the logging method invocations contains error code or not.

Since almost all logging method invocations have the corresponding error codes, and there're some absences of error codes in the 3.2 branch, in order to raise the awareness of the error code mechanism, I would like to start a discussion that about the timing of making the Error Code Inspector 'really' works.

Describe the proposal

Make the Error Code Inspector 'really' works after the 3.1 branch passes the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant