Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on error reporting of Error Code Inspector. #11182

Merged
merged 8 commits into from
Dec 22, 2022

Conversation

win120a
Copy link
Contributor

@win120a win120a commented Dec 21, 2022

What is the purpose of the change

Close #11127 .

Brief changelog

Change the report-as-error property.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #11182 (02048ad) into 3.1 (0b2a8f0) will decrease coverage by 4.62%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #11182      +/-   ##
============================================
- Coverage     69.29%   64.67%   -4.63%     
+ Complexity      127       14     -113     
============================================
  Files          1502     1422      -80     
  Lines         78949    59319   -19630     
  Branches      13842     8721    -5121     
============================================
- Hits          54711    38364   -16347     
+ Misses        19484    16910    -2574     
+ Partials       4754     4045     -709     
Impacted Files Coverage Δ
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
...ycenter/processor/KillProcessWindowsProcessor.java 10.00% <0.00%> (-80.00%) ⬇️
...nter/processor/StartZookeeperWindowsProcessor.java 17.39% <0.00%> (-78.27%) ⬇️
... and 493 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@win120a win120a changed the title Turn on error report of Error Code Inspector. Turn on error reporting of Error Code Inspector. Dec 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 0e549fb into apache:3.1 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Dubbo Error Code Inspector 'really' works.
3 participants