-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on error reporting of Error Code Inspector. #11182
Merged
AlbumenJ
merged 8 commits into
apache:3.1
from
win120a:1221_turn_on_error_report_of_eci
Dec 22, 2022
Merged
Turn on error reporting of Error Code Inspector. #11182
AlbumenJ
merged 8 commits into
apache:3.1
from
win120a:1221_turn_on_error_report_of_eci
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.1 #11182 +/- ##
============================================
- Coverage 69.29% 64.67% -4.63%
+ Complexity 127 14 -113
============================================
Files 1502 1422 -80
Lines 78949 59319 -19630
Branches 13842 8721 -5121
============================================
- Hits 54711 38364 -16347
+ Misses 19484 16910 -2574
+ Partials 4754 4045 -709
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
win120a
changed the title
Turn on error report of Error Code Inspector.
Turn on error reporting of Error Code Inspector.
Dec 22, 2022
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Close #11127 .
Brief changelog
Change the
report-as-error
property.