Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In telnet, typing special characters causes no response, and the client cannot run or quit. #13812

Closed
1 task done
Helltab opened this issue Mar 1, 2024 · 3 comments
Closed
1 task done

In telnet, typing special characters causes no response, and the client cannot run or quit. #13812

Helltab opened this issue Mar 1, 2024 · 3 comments
Assignees
@hengyoush
Labels
component/sdk Related with apache/dubbo help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@Helltab
Copy link

Helltab commented Mar 1, 2024 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 3.2.6
  • Operating System version: macos 14
  • Java version: jdk21

Steps to reproduce this issue

Describe: When type 'ctrl + c', telnet get '^c' and the client cannot run or quit.
Excepted result: quit or prompt 'no such command'
image
image
@Helltab Helltab added the type/need-triage Need maintainers to triage label Mar 1, 2024
@AlbumenJ AlbumenJ added help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance and removed type/need-triage Need maintainers to triage labels Mar 6, 2024
@AlbumenJ
Copy link
Member

AlbumenJ commented Mar 6, 2024

Can you please try to enhance it?

@AlbumenJ
Copy link
Member

AlbumenJ commented Mar 6, 2024

The problem is caused by org/apache/dubbo/qos/server/handler/QosProcessHandler.java:92

@hengyoush
Copy link
Contributor

I can try solve it , please assign it to me.

@AlbumenJ AlbumenJ added the component/sdk Related with apache/dubbo label Mar 11, 2024
hengyoush pushed a commit to hengyoush/dubbo that referenced this issue Mar 14, 2024
Fix telnet ctrl+c issue apache#13812
a07d241
@hengyoush hengyoush mentioned this issue Mar 15, 2024
Merged
7 tasks
AlbumenJ pushed a commit that referenced this issue Mar 22, 2024
@hengyoush
Fix telnet ctrl+c issue #13812 (#13921)
b338e20 
* Fix telnet ctrl+c issue #13812

* fix formatting issue

* add unit test for CtrlCHandler.java

---------

Co-authored-by: hengyouhai <hengyouhai@tuhu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hengyoush hengyoush

Labels
component/sdk Related with apache/dubbo help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Dubbo Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlbumenJ @Helltab @hengyoush