-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigCenterConfig's member field's key wrong #3682
Comments
I don't think the problem you described exists. |
I noticed the properties of ConfigCenterConfig is not read correctly by Dubbo Version 2.7.1
The code in
And it always be "dubbo", due to the url field The namespace is set by
|
#4411 The problem has been solved. Please ignore. |
Environment
I find some member fields of ConfigCenterConfig are annotated by @parameter, and the 'useKeyAsProperty' property of the annotation is set 'false'.
For example, the 'check' member field is annotated by @parameter, and its key is "config.check", but the 'useKeyAsProperty' is false.
So the key of this field in URL's parameters is 'check' because the 'useKeyAsProperty' is false, but in config center configuration class like ApolloDynamicConfiguration, the class use 'config.check' to get the property from parameters of URL.
So I think we should adjust the setting.
How about set the 'useKeyAsProperty' to true ?
I want to listen others' proposals.
Steps to reproduce this issue
config
Expected Result
the key in url's parameters should be "config.check", because in apollo dynamic configuration class, it use the key to get the check property
What do you expected from the above steps?
Actual Result
the key in parameters is check
If there is an exception, please attach the exception trace:
The text was updated successfully, but these errors were encountered: