Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url generated from ConfigCenterConfig missed 'config.' prefix #4411

Merged
merged 8 commits into from
Jul 5, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

see #3872

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@zhaixiaoxiang zhaixiaoxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also encounter this BUG. I've verified this modification. LGTM

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (2.7.3-release@cfba520). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##             2.7.3-release    #4411   +/-   ##
================================================
  Coverage                 ?   63.53%           
  Complexity               ?      452           
================================================
  Files                    ?      766           
  Lines                    ?    33639           
  Branches                 ?     5385           
================================================
  Hits                     ?    21374           
  Misses                   ?     9842           
  Partials                 ?     2423
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 87.5% <ø> (ø) 0 <0> (?)
...va/org/apache/dubbo/config/ConfigCenterConfig.java 83.07% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfba520...9163a6d. Read the comment docs.

@nzomkxia nzomkxia merged commit f456745 into apache:2.7.3-release Jul 5, 2019
@chickenlj chickenlj deleted the configcenterconfig-3872 branch September 3, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants