Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.7.2 AccessLogFilter #4374

Closed
gioxiao opened this issue Jun 24, 2019 · 1 comment
Closed

2.7.2 AccessLogFilter #4374

gioxiao opened this issue Jun 24, 2019 · 1 comment

Comments

@gioxiao
Copy link

gioxiao commented Jun 24, 2019

String accessLogKey = invoker.getUrl().getParameter(ACCESS_LOG_KEY);
是不是应该改成
String accessLogKey = invoker.getUrl().getParameter(Constants.ACCESS_LOG_KEY);
url里面没有dubbo.accesslog参数
@kexianjun
Copy link
Member

no, pls see the import statement

import static org.apache.dubbo.rpc.Constants.ACCESS_LOG_KEY;

lonre added a commit to lonre/dubbo that referenced this issue Jul 13, 2019
@lonre
Fix bug apache#4374 for AccessLogFilter not working, which introduced…
c41c4e0 
… by apache#4038
lonre added a commit to lonre/dubbo that referenced this issue Jul 13, 2019
@lonre
Fix bug apache#4374 for AccessLogFilter not working
f03b983 
which introduced by apache#4038
beiwei30 pushed a commit that referenced this issue Jul 15, 2019
@lonre @beiwei30
Fix bug #4374 for AccessLogFilter not working (#4566)
05e44db 
which introduced by #4038
@dubbo-bot dubbo-bot mentioned this issue Jul 19, 2019
Closed
@jicro jicro mentioned this issue Nov 5, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kexianjun @gioxiao