Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize some code related to consul #7518

Closed
2 tasks
xiaoheng1 opened this issue Apr 8, 2021 · 0 comments
Closed
2 tasks

Optimize some code related to consul #7518

xiaoheng1 opened this issue Apr 8, 2021 · 0 comments

Comments

@xiaoheng1
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.x
  • Operating System version: macos
  • Java version: 1.7.8

motivation

I checked the consul part of the code and found that some parameters of the configcenter, metadata, and registry modules implemented by consul are the same. Extract these to the common module, and configcenter, metadata, and registry share the same configuration.
xiaoheng1 added a commit to xiaoheng1/incubator-dubbo that referenced this issue Apr 8, 2021
@xiaoheng1
fix apache#7518 Optimize some code related to consul
4ef8bfe
@xiaoheng1 xiaoheng1 mentioned this issue Apr 9, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiaoheng1