Provider supports thread pool isolation between services #10658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.2 #10658 +/- ##
============================================
+ Coverage 65.30% 65.43% +0.13%
+ Complexity 416 392 -24
============================================
Files 1338 1347 +9
Lines 57058 57189 +131
Branches 8452 8464 +12
============================================
+ Hits 37262 37422 +160
+ Misses 15829 15806 -23
+ Partials 3967 3961 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
…emoved) 2.Consumers should not involved in service thread pool isolation
BurningCN
force-pushed
the
Supports_thread_pool_isolation_between_services
branch
from
e141895 to
f15d954
Compare
# Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java # dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/AbstractServiceBuilder.java # dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractInvoker.java
# Conflicts: # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/transport/TripleHttp2FrameServerHandler.java
EarthChen
requested changes
Oct 26, 2022
| } | ||
|
|
||
| @Override | ||
| protected ServiceKey getServiceKey(Object data) { |
There was a problem hiding this comment.
The servicekey seems to have been obtained in onheader, can it be reused? But there is a problem here, onheader is already in the business thread pool, you may need to pay attention
| @@ -109,6 +107,8 @@ public void onDataRead(ChannelHandlerContext ctx, Http2DataFrame msg) throws Exc | |||
| } | |||
|
|
|||
| public void onHeadersRead(ChannelHandlerContext ctx, Http2HeadersFrame msg) throws Exception { | |||
| Executor executor = executorSupport.getExecutor(msg); | |||
There was a problem hiding this comment.
I think that the calculation of the thread pool can be put into the onheader method, and the previous part of the logic can be executed in the eventloop. (Only basic judgment, no complex logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see apache/dubbo-awesome#92 (comment)