Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dump thread switch and directory config #10955

Merged

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Nov 18, 2022

What is the purpose of the change

closed #10563

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@CrazyHZM CrazyHZM added this to the 3.2.0 milestone Nov 18, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 19 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.67%. Comparing base (a931777) to head (70ad83e).
Report is 1816 commits behind head on 3.2.

Files with missing lines Patch % Lines
...mmon/threadpool/support/AbortPolicyWithReport.java 0.00% 2 Missing ⚠️
...ava/org/apache/dubbo/config/ApplicationConfig.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #10955      +/-   ##
============================================
- Coverage     20.67%   20.67%   -0.01%     
  Complexity       14       14              
============================================
  Files          1441     1441              
  Lines         59690    59707      +17     
  Branches       8758     8762       +4     
============================================
+ Hits          12341    12343       +2     
- Misses        45269    45284      +15     
  Partials       2080     2080              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chickenlj
Copy link
Contributor

https://dubbo.apache.org/zh/docs3-v2/java-sdk/advanced-features-and-usage/performance/dump/

@CrazyHZM Could you please also keep the documentation here synchoronized?

@chickenlj chickenlj self-requested a review November 21, 2022 02:13
@CrazyHZM
Copy link
Member Author

https://dubbo.apache.org/zh/docs3-v2/java-sdk/advanced-features-and-usage/performance/dump/

@CrazyHZM Could you please also keep the documentation here synchoronized?

@chickenlj Sure

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit d327fea into apache:3.2 Dec 5, 2022
@CrazyHZM CrazyHZM deleted the feat/support_dump_thread_switch_config branch December 5, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make dumpJStack configurable when server side threadpool is exhausted
4 participants