【fix】forking cluster #11063
Merged
【fix】forking cluster #11063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyHZM
requested changes
Dec 5, 2022
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
Outdated
Show resolved
Hide resolved
| for (final Invoker<T> invoker : selected) { | ||
| final CountDownLatch countDownLatch = new CountDownLatch(1); | ||
| AtomicReference<Object> result = new AtomicReference<>(); | ||
| selected.forEach(invoker -> { |
There was a problem hiding this comment.
It looks like CompletableFuture.anyOf can satisfy this requirement.
There was a problem hiding this comment.
need consider exception case
n provider first n-1 exceptions need to be ignored
CrazyHZM
requested changes
Dec 9, 2022
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
Outdated
Show resolved
Hide resolved
|
@XDanwar Please complete this section in the 3.2 branch. |
done |
Codecov Report
@@ Coverage Diff @@
## 3.2 #11063 +/- ##
============================================
- Coverage 64.93% 64.86% -0.07%
Complexity 14 14
============================================
Files 1462 1471 +9
Lines 60911 61244 +333
Branches 8937 8980 +43
============================================
+ Hits 39551 39725 +174
- Misses 17182 17315 +133
- Partials 4178 4204 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zeusbee
requested review from
EarthChen
and removed request for
CrazyHZM and
EarthChen
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletableFuture + CountDownLatch 实现 ForkingClusterInvoker 调用provider
issue: #11052