Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: throw a NPE in deserialization process when one property of java.sql.Time type happens to be null #1118

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

windlaughing
Copy link

What is the purpose of the change

RPC调用反序列化过程中,如果对象的成员变量的类型为java.sql.Time,且其值为NULL,则抛出NPE。

Brief changelog

添加了必要的非空检查

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2017

CLA assistant check
All committers have signed the CLA.

@chickenlj chickenlj changed the title bugfix:RPC调用反序列化,java.sql.Time类型属性为NULL时,抛出NPE bugfix: throw a NPE in deserialization process when one property of java.sql.Time type happens to be null Jan 4, 2018
@chickenlj
Copy link
Contributor

That's a hessian serialization problem, and i think your solution can works fine.
But can you add a unit test for this change?

@chickenlj chickenlj added this to the 2.5.9 milestone Jan 4, 2018
@chickenlj chickenlj removed the status/waiting-for-feedback Need reporters to triage label Jan 17, 2018
@chickenlj chickenlj changed the base branch from master to 2.5.x January 17, 2018 09:26
@chickenlj chickenlj merged commit d192720 into apache:2.5.x Jan 17, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…em for java.sql.Time.

Add null check for java.sql.Time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants