Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error code in 3.2 branch #11199

Merged
merged 2 commits into from
Dec 25, 2022
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022

Codecov Report

Merging #11199 (2d411f1) into 3.2 (459a0f9) will increase coverage by 0.07%.
The diff coverage is 56.81%.

@@             Coverage Diff              @@
##                3.2   #11199      +/-   ##
============================================
+ Coverage     64.74%   64.81%   +0.07%     
  Complexity       14       14              
============================================
  Files          1479     1479              
  Lines         61588    61583       -5     
  Branches       9029     9029              
============================================
+ Hits          39877    39917      +40     
+ Misses        17522    17481      -41     
+ Partials       4189     4185       -4     
Impacted Files Coverage Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 38.09% <0.00%> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 69.58% <0.00%> (ø)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 74.31% <0.00%> (ø)
...ng/transport/netty/NettyPortUnificationServer.java 0.00% <0.00%> (ø)
.../org/apache/dubbo/registry/xds/istio/IstioEnv.java 0.00% <0.00%> (ø)
...oting/api/connection/AbstractConnectionClient.java 71.42% <50.00%> (ø)
...moting/transport/netty4/NettyConnectionClient.java 75.48% <50.00%> (+1.29%) ⬆️
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 69.91% <50.00%> (+0.24%) ⬆️
...rpc/cluster/router/xds/RdsVirtualHostListener.java 83.13% <50.00%> (ø)
.../protocol/dubbo/DubboIsolationExecutorSupport.java 71.42% <77.77%> (+12.60%) ⬆️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
7.3% 7.3% Duplication

@AlbumenJ AlbumenJ merged commit 2a7dd3d into apache:3.2 Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants