Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zookeeper instance update #11212

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Fix zookeeper instance update #11212

merged 1 commit into from
Dec 29, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ requested a review from chickenlj December 28, 2022 12:01
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj
Copy link
Contributor

The interval between the unregister and register mode before might cause this instance unavailable.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11212 (758babe) into 3.1 (98c2f39) will decrease coverage by 5.09%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                3.1   #11212      +/-   ##
============================================
- Coverage     69.45%   64.36%   -5.10%     
+ Complexity      128       14     -114     
============================================
  Files          1503     1422      -81     
  Lines         79374    59332   -20042     
  Branches      13986     8723    -5263     
============================================
- Hits          55132    38191   -16941     
+ Misses        19484    17089    -2395     
+ Partials       4758     4052     -706     
Impacted Files Coverage Δ
.../registry/zookeeper/ZookeeperServiceDiscovery.java 65.55% <71.42%> (-11.44%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
...ycenter/processor/KillProcessWindowsProcessor.java 10.00% <0.00%> (-80.00%) ⬇️
... and 512 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit e86e6e3 into apache:3.1 Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants