Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some qos command logs #11224

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Add some qos command logs #11224

merged 3 commits into from
Dec 30, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ requested a review from CrazyHZM December 30, 2022 09:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11224 (11132ef) into 3.1 (f03f374) will increase coverage by 0.02%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                3.1   #11224      +/-   ##
============================================
+ Coverage     64.39%   64.41%   +0.02%     
  Complexity       14       14              
============================================
  Files          1422     1422              
  Lines         59268    59281      +13     
  Branches       8713     8713              
============================================
+ Hits          38165    38186      +21     
+ Misses        17045    17039       -6     
+ Partials       4058     4056       -2     
Impacted Files Coverage Δ
...ache/dubbo/qos/command/DefaultCommandExecutor.java 82.60% <71.42%> (-17.40%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 72.64% <0.00%> (-1.89%) ⬇️
...ntext/event/AwaitingNonWebApplicationListener.java 70.66% <0.00%> (-1.34%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 79.16% <0.00%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 79.62% <0.00%> (+0.15%) ⬆️
...adata/store/zookeeper/ZookeeperMetadataReport.java 72.34% <0.00%> (+1.06%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0.00%> (+1.13%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 82.14% <0.00%> (+1.19%) ⬆️
...uster/loadbalance/ShortestResponseLoadBalance.java 91.04% <0.00%> (+1.49%) ⬆️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 78.68% <0.00%> (+2.45%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 7396970 into apache:3.1 Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants