-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapping retry #11265
Add mapping retry #11265
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.1 #11265 +/- ##
============================================
- Coverage 69.61% 64.45% -5.17%
+ Complexity 128 14 -114
============================================
Files 1503 1422 -81
Lines 80067 59365 -20702
Branches 14135 8725 -5410
============================================
- Hits 55741 38261 -17480
+ Misses 19543 17043 -2500
+ Partials 4783 4061 -722
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
logger.error(CONFIG_SERVER_DISCONNECTED, "configuration server disconnected", "", "Failed register interface application mapping for service " + url.getServiceKey(), e); | ||
} | ||
ScheduledExecutorService scheduledExecutor = getScopeModel().getBeanFactory() | ||
.getBean(FrameworkExecutorRepository.class).getSharedScheduledExecutor(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about put this ScheduledExecutorService scheduledExecutor = getScopeModel().getBeanFactory() .getBean(FrameworkExecutorRepository.class).getSharedScheduledExecutor();
snippet inside mapServiceName
, because I see it's only used by mapServiceName
.
What is the purpose of the change
Add service name mapping fail retry
Brief changelog
Verifying this change
Checklist