Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countdown assignment problem #11275

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Fix countdown assignment problem #11275

merged 5 commits into from
Jan 12, 2023

Conversation

CrazyHZM
Copy link
Member

Signed-off-by: crazyhzm crazyhzm@gmail.com

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@CrazyHZM CrazyHZM added this to the 3.1.5 milestone Jan 11, 2023
@AlbumenJ
Copy link
Member

image

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.6% 13.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11275 (e811d73) into 3.1 (67993e1) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##                3.1   #11275   +/-   ##
=========================================
  Coverage     64.51%   64.51%           
  Complexity       14       14           
=========================================
  Files          1427     1427           
  Lines         59703    59682   -21     
  Branches       8785     8782    -3     
=========================================
- Hits          38515    38504   -11     
+ Misses        17116    17110    -6     
+ Partials       4072     4068    -4     
Impacted Files Coverage Δ
.../cluster/filter/support/ConsumerContextFilter.java 60.41% <0.00%> (ø)
...in/java/org/apache/dubbo/rpc/support/RpcUtils.java 59.44% <41.66%> (-1.63%) ⬇️
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 71.18% <100.00%> (+7.41%) ⬆️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 63.20% <100.00%> (+1.71%) ⬆️
...g/apache/dubbo/rpc/protocol/tri/TripleInvoker.java 64.12% <100.00%> (+2.31%) ⬆️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 51.51% <0.00%> (-9.10%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-6.82%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 61.03% <0.00%> (-3.90%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 78.12% <0.00%> (-3.13%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 60.00% <0.00%> (-2.11%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CrazyHZM CrazyHZM requested a review from AlbumenJ January 12, 2023 06:26
@AlbumenJ AlbumenJ merged commit 7a5680b into apache:3.1 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants