Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization and deserialization use classes in the wrapper #11302

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Serialization and deserialization use classes in the wrapper #11302

merged 9 commits into from
Jan 17, 2023

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen EarthChen changed the title Tri use wrapper type Serialization and deserialization use classes in the wrapper Jan 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Merging #11302 (1770361) into 3.1 (f9b27ed) will increase coverage by 0.10%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##                3.1   #11302      +/-   ##
============================================
+ Coverage     64.48%   64.58%   +0.10%     
  Complexity       14       14              
============================================
  Files          1428     1428              
  Lines         59699    59766      +67     
  Branches       8785     8794       +9     
============================================
+ Hits          38497    38600     +103     
+ Misses        17124    17095      -29     
+ Partials       4078     4071       -7     
Impacted Files Coverage Δ
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 80.52% <75.00%> (-0.76%) ⬇️
...java/org/apache/dubbo/common/utils/ClassUtils.java 82.28% <100.00%> (+0.10%) ⬆️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 51.51% <0.00%> (-9.10%) ⬇️
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 67.79% <0.00%> (-3.39%) ⬇️
...va/org/apache/dubbo/registry/RegistryNotifier.java 74.35% <0.00%> (-2.57%) ⬇️
...bo/rpc/cluster/support/AbstractClusterInvoker.java 79.47% <0.00%> (-0.67%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 87.06% <0.00%> (+0.86%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 68.88% <0.00%> (+1.11%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 82.14% <0.00%> (+1.19%) ⬆️
...o/registry/nacos/util/NacosNamingServiceUtils.java 79.48% <0.00%> (+1.90%) ⬆️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.8% 75.8% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 8cc3539 into apache:3.1 Jan 17, 2023
KamToHung pushed a commit to KamToHung/dubbo that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants