Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nacos sub try test #11307

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add Nacos sub try test #11307

merged 1 commit into from
Jan 16, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
10.6% 10.6% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11307 (63909b9) into 3.1 (007b6bf) will decrease coverage by 1.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #11307      +/-   ##
============================================
- Coverage     65.65%   64.56%   -1.09%     
+ Complexity       20       14       -6     
============================================
  Files          1428     1428              
  Lines         59757    59762       +5     
  Branches       8827     8794      -33     
============================================
- Hits          39232    38587     -645     
- Misses        16452    17108     +656     
+ Partials       4073     4067       -6     
Impacted Files Coverage Δ
...enter/support/nacos/NacosDynamicConfiguration.java 33.56% <100.00%> (+1.91%) ⬆️
...ubbo/metadata/store/nacos/NacosMetadataReport.java 20.73% <100.00%> (+1.48%) ⬆️
...o/registry/nacos/util/NacosNamingServiceUtils.java 79.48% <100.00%> (+1.10%) ⬆️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
... and 100 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 486b39f into apache:3.1 Jan 16, 2023
KamToHung pushed a commit to KamToHung/dubbo that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants