-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics key duplication #11349
metrics key duplication #11349
Conversation
…beta.3 # Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java # dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/stat/MetricsStatComposite.java # dubbo-common/src/main/java/org/apache/dubbo/common/metrics/event/RequestEvent.java # dubbo-common/src/main/java/org/apache/dubbo/common/metrics/model/MetricsKey.java # dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/collector/AggregateMetricsCollector.java # dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/MetricsFilterTest.java
…ture-dubbo-3.2.0-beta.3 # Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/metrics/collector/DefaultMetricsCollector.java # dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/MetricsFilterTest.java
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.2.0-beta.4-release #11349 +/- ##
==========================================================
- Coverage 65.89% 64.84% -1.05%
+ Complexity 20 14 -6
==========================================================
Files 1486 1486
Lines 62356 62352 -4
Branches 9165 9132 -33
==========================================================
- Hits 41091 40435 -656
- Misses 17070 17718 +648
- Partials 4195 4199 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
metrics key duplication