Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods synchronized to match parent declaration #11383

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

sconvent
Copy link
Contributor

@sconvent sconvent commented Jan 23, 2023

What is the purpose of the change

Some methods are declared to not be synchronized, but they override a synchronized method declared in their parent.
This practically breaks the contract stated by the parent class. I'm not aware of any actual problem that this causes but nontheless, it should be fixed.

Brief changelog

Adding a synchronized statement to overriding methods that were missing it.

Verifying this change

Not really testable, so there is no way to verify it.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11383 (8be9253) into 3.2 (54bb276) will decrease coverage by 4.82%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11383      +/-   ##
============================================
- Coverage     69.63%   64.81%   -4.82%     
+ Complexity      133       14     -119     
============================================
  Files          1515     1487      -28     
  Lines         82452    62370   -20082     
  Branches      14757     9133    -5624     
============================================
- Hits          57415    40425   -16990     
+ Misses        20199    17727    -2472     
+ Partials       4838     4218     -620     
Impacted Files Coverage Δ
.../org/apache/dubbo/common/cache/FileCacheStore.java 84.09% <ø> (-8.28%) ⬇️
...n/java/org/apache/dubbo/common/io/StreamUtils.java 84.04% <ø> (-2.13%) ⬇️
...ubbo/remoting/buffer/ChannelBufferInputStream.java 94.44% <ø> (ø)
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
... and 481 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
Copy link
Member

Thanks for your contribution :)

@AlbumenJ AlbumenJ merged commit d28b224 into apache:3.2 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants