Make methods synchronized to match parent declaration #11383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Some methods are declared to not be synchronized, but they override a synchronized method declared in their parent.
This practically breaks the contract stated by the parent class. I'm not aware of any actual problem that this causes but nontheless, it should be fixed.
Brief changelog
Adding a
synchronized
statement to overriding methods that were missing it.Verifying this change
Not really testable, so there is no way to verify it.
Checklist