Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 🐛 fix metrics filter path #11392

Merged
merged 11 commits into from
Jan 30, 2023
Merged

🐛 🐛 fix metrics filter path #11392

merged 11 commits into from
Jan 30, 2023

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

🐛 fix metrics filter path

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #11392 (87fa520) into 3.2 (d8e6dfa) will decrease coverage by 4.75%.
The diff coverage is 59.26%.

@@             Coverage Diff              @@
##                3.2   #11392      +/-   ##
============================================
- Coverage     69.54%   64.80%   -4.75%     
+ Complexity      132       14     -118     
============================================
  Files          1503     1497       -6     
  Lines         80071    62498   -17573     
  Branches      14133     9146    -4987     
============================================
- Hits          55688    40500   -15188     
+ Misses        19591    17764    -1827     
+ Partials       4792     4234     -558     
Impacted Files Coverage Δ
...ache/dubbo/rpc/cluster/CacheableRouterFactory.java 0.00% <0.00%> (ø)
.../cluster/filter/support/ConsumerContextFilter.java 61.22% <0.00%> (-9.51%) ⬇️
...o/rpc/cluster/router/script/ScriptStateRouter.java 0.00% <0.00%> (-73.34%) ⬇️
.../org/apache/dubbo/common/cache/FileCacheStore.java 84.09% <ø> (-8.28%) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...n/java/org/apache/dubbo/common/io/StreamUtils.java 84.04% <ø> (-2.13%) ⬇️
.../dubbo/common/utils/ClassLoaderResourceLoader.java 74.50% <ø> (-2.52%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 61.99% <0.00%> (-10.87%) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 80.57% <ø> (-3.79%) ⬇️
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 8.33% <0.00%> (-0.56%) ⬇️
... and 600 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit f73eee9 into apache:3.2 Jan 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants