Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Check #11419

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Enhance Check #11419

merged 6 commits into from
Feb 1, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #11419 (8102d62) into 3.1 (f1b3e55) will increase coverage by 0.06%.
The diff coverage is 92.74%.

@@             Coverage Diff              @@
##                3.1   #11419      +/-   ##
============================================
+ Coverage     64.56%   64.63%   +0.06%     
  Complexity       14       14              
============================================
  Files          1428     1428              
  Lines         59779    59891     +112     
  Branches       8794     8805      +11     
============================================
+ Hits          38598    38710     +112     
- Misses        17101    17113      +12     
+ Partials       4080     4068      -12     
Impacted Files Coverage Δ
...e/dubbo/common/utils/AllowClassNotifyListener.java 100.00% <ø> (ø)
.../serialize/fastjson2/Fastjson2SecurityManager.java 43.54% <64.00%> (+10.21%) ⬆️
...mon/serialize/hessian2/Hessian2FactoryManager.java 38.77% <66.66%> (ø)
...he/dubbo/rpc/protocol/ProtocolSecurityWrapper.java 83.78% <84.61%> (-9.55%) ⬇️
...bo/common/utils/SerializeSecurityConfigurator.java 94.73% <94.73%> (ø)
...bbo/common/utils/DefaultSerializeClassChecker.java 92.77% <95.74%> (ø)
...ache/dubbo/common/CommonScopeModelInitializer.java 100.00% <100.00%> (ø)
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 80.79% <100.00%> (-0.07%) ⬇️
.../java/org/apache/dubbo/common/utils/PojoUtils.java 75.88% <100.00%> (-0.06%) ⬇️
...pache/dubbo/common/utils/SerializeCheckStatus.java 100.00% <100.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

86.6% 86.6% Coverage
0.0% 0.0% Duplication

@chickenlj chickenlj self-requested a review February 1, 2023 06:39
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj requested a review from CrazyHZM February 1, 2023 07:21
@chickenlj
Copy link
Contributor

@CrazyHZM PTAL

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit c71a05a into apache:3.1 Feb 1, 2023
win120a pushed a commit to win120a/dubbo that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants