Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tri future #11455

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Fix tri future #11455

merged 5 commits into from
Feb 6, 2023

Conversation

EarthChen
Copy link
Member

@EarthChen EarthChen commented Feb 3, 2023

What is the purpose of the change

fix #11447 not stub

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen EarthChen requested review from AlbumenJ and guohao February 4, 2023 05:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 4 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11455 (bbf6007) into 3.1 (34b92b0) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                3.1   #11455      +/-   ##
============================================
- Coverage     64.67%   64.63%   -0.04%     
  Complexity       14       14              
============================================
  Files          1431     1431              
  Lines         59969    59971       +2     
  Branches       8807     8807              
============================================
- Hits          38786    38765      -21     
- Misses        17111    17124      +13     
- Partials       4072     4082      +10     
Impacted Files Coverage Δ
...ubbo/rpc/protocol/tri/call/AbstractServerCall.java 51.12% <0.00%> (-0.59%) ⬇️
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 77.22% <50.00%> (ø)
...gistrycenter/processor/ZookeeperUnixProcessor.java 60.71% <0.00%> (-17.86%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 64.28% <0.00%> (-9.53%) ⬇️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 51.51% <0.00%> (-9.10%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-8.70%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-7.96%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.64% <0.00%> (-3.23%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 72.64% <0.00%> (-2.84%) ⬇️
...ntext/event/AwaitingNonWebApplicationListener.java 70.66% <0.00%> (-1.34%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EarthChen EarthChen merged commit 0489702 into apache:3.1 Feb 6, 2023
win120a pushed a commit to win120a/dubbo that referenced this pull request Feb 9, 2023
* fix tri return future

* fix ut

* fix npe

* fix sonar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants