Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #11459

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Remove unused code #11459

merged 1 commit into from
Apr 11, 2023

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen EarthChen changed the base branch from 3.2 to 3.1 February 4, 2023 12:49
@codecov-commenter
Copy link

Codecov Report

Merging #11459 (a51cb1e) into 3.1 (34b92b0) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #11459      +/-   ##
============================================
+ Coverage     64.67%   64.89%   +0.21%     
  Complexity       14       14              
============================================
  Files          1431     1502      +71     
  Lines         59969    62734    +2765     
  Branches       8807     9162     +355     
============================================
+ Hits          38786    40712    +1926     
- Misses        17111    17786     +675     
- Partials       4072     4236     +164     
Impacted Files Coverage Δ
...ri/transport/TripleHttp2ClientResponseHandler.java 91.42% <ø> (-0.24%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...mmon/serialize/hessian2/Hessian2Serialization.java 15.38% <0.00%> (-76.93%) ⬇️
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 0.00% <0.00%> (-37.84%) ⬇️
...common/serialize/hessian2/Hessian2ObjectInput.java 0.00% <0.00%> (-37.50%) ⬇️
...o/rpc/protocol/tri/transport/GracefulShutdown.java 51.85% <0.00%> (-29.63%) ⬇️
...mon/serialize/hessian2/Hessian2FactoryManager.java 14.28% <0.00%> (-24.49%) ⬇️
...bbo/remoting/buffer/ChannelBufferOutputStream.java 68.75% <0.00%> (-18.75%) ⬇️
...ache/dubbo/rpc/protocol/dubbo/DubboCountCodec.java 76.31% <0.00%> (-14.31%) ⬇️
...common/serialize/DefaultMultipleSerialization.java 85.71% <0.00%> (-14.29%) ⬇️
... and 368 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 502 Code Smells

52.3% 52.3% Coverage
2.4% 2.4% Duplication

@EarthChen EarthChen requested a review from guohao February 6, 2023 02:43
@EarthChen EarthChen added the status/don’t-merge No plan to merge label Feb 6, 2023
@AlbumenJ AlbumenJ merged commit 6b1de07 into apache:3.1 Apr 11, 2023
@AlbumenJ AlbumenJ removed the status/don’t-merge No plan to merge label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants