Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the code of metrics registry&metadata #11659

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Feb 25, 2023

What is the purpose of the change

code pot
relate #11593 #11493

Brief changelog

1、Move the container class used by both the registry and the metadata center into the public module
2、Add unit tests and remove dup unit tests

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #11659 (1f11b8c) into 3.2 (837b9c5) will decrease coverage by 0.70%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11659      +/-   ##
============================================
- Coverage     69.66%   68.97%   -0.70%     
+ Complexity      341        2     -339     
============================================
  Files          3116     1499    -1617     
  Lines        147990    62506   -85484     
  Branches      24658     9210   -15448     
============================================
- Hits         103095    43112   -59983     
+ Misses        35718    15164   -20554     
+ Partials       9177     4230    -4947     
Impacted Files Coverage Δ
...apache/dubbo/rpc/cluster/router/tag/model/Tag.java 73.07% <0.00%> (-19.24%) ⬇️
...ain/java/org/apache/dubbo/common/utils/Assert.java 55.55% <0.00%> (-15.88%) ⬇️
...er/mesh/rule/virtualservice/match/StringMatch.java 87.87% <0.00%> (-12.13%) ⬇️
...router/condition/config/AppStateRouterFactory.java 88.88% <0.00%> (-11.12%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 47.72% <0.00%> (-9.10%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-8.70%) ⬇️
...cluster/router/condition/ConditionStateRouter.java 61.29% <0.00%> (-7.68%) ⬇️
.../dubbo/common/url/component/ServiceAddressURL.java 47.25% <0.00%> (-6.50%) ⬇️
...bbo/common/concurrent/CallableSafeInitializer.java 61.90% <0.00%> (-4.77%) ⬇️
...registry/collector/stat/RegistryStatComposite.java 76.47% <0.00%> (-4.43%) ⬇️
... and 1746 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

4.9% 4.9% Coverage
0.6% 0.6% Duplication

@AlbumenJ AlbumenJ merged commit ef29a41 into apache:3.2 Mar 2, 2023
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
* registry&metadata opt

* add licence

* fix sonar

* fix enable failed

* fix enable failed

* add registry&metadata in spring/xsd

---------

Co-authored-by: x-shadow-man <1494445739@qq.com>
@wxbty wxbty deleted the metrics-opt branch March 31, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants