Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : delete never thrown exception #11674

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

erdengk
Copy link
Contributor

@erdengk erdengk commented Feb 27, 2023

What is the purpose of the change

Delete unnecessary exceptions thrown in the test.
Types such as:
Exception 'java.io.IOException' is never thrown in the method

This is the first PR, expect 3 more.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@erdengk
Copy link
Contributor Author

erdengk commented Feb 27, 2023

@AlbumenJ
Please allow this pr to start workflow testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11674 (c15e0f3) into 3.2 (a70cc27) will decrease coverage by 2.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11674      +/-   ##
============================================
- Coverage     69.34%   67.15%   -2.20%     
+ Complexity      315        2     -313     
============================================
  Files          1691     1612      -79     
  Lines         88202    65217   -22985     
  Branches      16012     9440    -6572     
============================================
- Hits          61168    43795   -17373     
+ Misses        21908    17153    -4755     
+ Partials       5126     4269     -857     
Impacted Files Coverage Δ
...g/apache/dubbo/maven/plugin/aot/IncludeFilter.java
.../org/apache/dubbo/remoting/ExecutionException.java
.../security/model/SecurityScopeModelInitializer.java
...ster/router/mesh/route/StandardMeshRuleRouter.java
...notation/ReferenceAnnotationBeanPostProcessor.java
...bbo/common/status/support/MemoryStatusChecker.java
...moting/transport/netty4/NettyConnectionClient.java
...ubbo/remoting/http/support/AbstractHttpServer.java
...er/condition/config/model/ConditionRuleParser.java
...n/java/org/apache/dubbo/qos/command/impl/Help.java
... and 3293 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 7e51047 into apache:3.2 Feb 27, 2023
@erdengk erdengk deleted the delete_never_thrown_exception branch February 27, 2023 12:58
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
* origin/3.2:
  Fix heartbeat failed if serialization changed (apache#11512)
  Update README.md
  Tag router problem fix (apache#11586)
  delete never thrown exception (apache#11674)
  ♻️refact metrics key and meter unit (apache#11661)
  feat: optimize code (apache#11671)
  Introduce getConfig QoS Command (apache#11664)
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants