Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code optimization #11683

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Some code optimization #11683

merged 1 commit into from
Feb 28, 2023

Conversation

mytang0
Copy link
Member

@mytang0 mytang0 commented Feb 28, 2023

What is the purpose of the change

  1. Made some modifier optimizations
  2. Added some SuppressWarnings

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 11 Code Smells

97.1% 97.1% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11683 (8d579ab) into 3.2 (32ada24) will increase coverage by 0.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11683      +/-   ##
============================================
+ Coverage     68.54%   69.05%   +0.50%     
+ Complexity      341        2     -339     
============================================
  Files          3307     1499    -1808     
  Lines        153492    62622   -90870     
  Branches      25424     9219   -16205     
============================================
- Hits         105208    43242   -61966     
+ Misses        38891    15150   -23741     
+ Partials       9393     4230    -5163     
Impacted Files Coverage Δ
...router/condition/config/AppStateRouterFactory.java 88.88% <0.00%> (-11.12%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) ⬇️
...oting/transport/netty4/NettyConnectionHandler.java 53.19% <0.00%> (-6.39%) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) ⬇️
...bbo/common/concurrent/CallableSafeInitializer.java 61.90% <0.00%> (-4.77%) ⬇️
...pache/dubbo/common/lang/ShutdownHookCallbacks.java 95.65% <0.00%> (-4.35%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 61.34% <0.00%> (-2.53%) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 91.83% <0.00%> (-2.05%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 77.04% <0.00%> (-1.64%) ⬇️
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 80.28% <0.00%> (-1.41%) ⬇️
... and 1827 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit ed9e26f into apache:3.2 Feb 28, 2023
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants