Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata proxy load filter #11769

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix metadata proxy load filter #11769

merged 1 commit into from
Mar 10, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Mar 8, 2023

What is the purpose of the change

Fix #11716

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11769 (3bfb17d) into 3.1 (7277c15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                3.1   #11769   +/-   ##
=========================================
  Coverage     64.68%   64.69%           
  Complexity       14       14           
=========================================
  Files          1431     1431           
  Lines         60034    60034           
  Branches       8827     8827           
=========================================
+ Hits          38832    38838    +6     
+ Misses        17119    17115    -4     
+ Partials       4083     4081    -2     
Impacted Files Coverage Δ
.../dubbo/registry/client/metadata/MetadataUtils.java 65.74% <100.00%> (ø)
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 64.28% <0.00%> (-9.53%) ⬇️
...ache/dubbo/common/extension/ExtensionDirector.java 93.33% <0.00%> (-3.34%) ⬇️
...egistry/kubernetes/KubernetesServiceDiscovery.java 77.83% <0.00%> (-2.36%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 80.95% <0.00%> (-1.20%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 72.64% <0.00%> (-0.95%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 61.57% <0.00%> (+0.52%) ⬆️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 77.04% <0.00%> (+0.81%) ⬆️
...adata/store/zookeeper/ZookeeperMetadataReport.java 72.34% <0.00%> (+1.06%) ⬆️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 83.87% <0.00%> (+3.22%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 16c61c5 into apache:3.1 Mar 10, 2023
@AlbumenJ
Copy link
Member Author

Integration test cases: apache/dubbo-samples#786

lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants