Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1、fix after offline and online error #12044

Merged

Conversation

xieshouyu
Copy link
Contributor

What is the purpose of the change

1、After the QoS offline, executing the QoS online will report an error

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.69%. Comparing base (9a4aadd) to head (1a53e96).
Report is 23 commits behind head on 3.1.

Files with missing lines Patch % Lines
...he/dubbo/registry/nacos/NacosServiceDiscovery.java 9.09% 10 Missing ⚠️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.1   #12044      +/-   ##
============================================
- Coverage     64.70%   64.69%   -0.02%     
  Complexity       14       14              
============================================
  Files          1433     1433              
  Lines         60084    60086       +2     
  Branches       8830     8832       +2     
============================================
- Hits          38879    38870       -9     
- Misses        17118    17131      +13     
+ Partials       4087     4085       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit d2f4ef1 into apache:3.1 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants