Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest provider interface judge modify #12163

Merged
merged 6 commits into from
May 2, 2023
Merged

rest provider interface judge modify #12163

merged 6 commits into from
May 2, 2023

Conversation

suncairong163
Copy link
Contributor

What is the purpose of the change

rest provider impl class support by changing service config interface judge

Brief changelog

Verifying this change

@AlbumenJ

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #12163 (b3fce98) into 3.2 (e3600af) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12163      +/-   ##
============================================
- Coverage     69.93%   69.50%   -0.44%     
+ Complexity      103        2     -101     
============================================
  Files          3405     1593    -1812     
  Lines        159372    65456   -93916     
  Branches      26318     9531   -16787     
============================================
- Hits         111457    45494   -65963     
+ Misses        38234    15579   -22655     
+ Partials       9681     4383    -5298     

see 1902 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -297,6 +296,22 @@ public void setInterface(Class<?> interfaceClass) {
}
}

public boolean containsRestProtocol() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert Overrided annotation

@@ -374,6 +375,10 @@ protected void processExtraRefresh(String preferredPrefix, InmemoryConfiguration

}

protected boolean containsRestProtocol() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected boolean containsRestProtocol() {
protected boolean canSkipInterfaceCheck() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, add some comment for this method

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit ab85403 into apache:3.2 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants