Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe occurs during client graceful offline. #12190

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12190 (aa664c6) into 3.2 (e3600af) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12190      +/-   ##
============================================
- Coverage     69.93%   69.54%   -0.40%     
+ Complexity      103        2     -101     
============================================
  Files          3405     1593    -1812     
  Lines        159372    65440   -93932     
  Branches      26318     9526   -16792     
============================================
- Hits         111457    45508   -65949     
+ Misses        38234    15542   -22692     
+ Partials       9681     4390    -5291     

see 1885 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 83240f5 into apache:3.2 Apr 27, 2023
@CrazyHZM CrazyHZM deleted the fix/npe_client_graceful branch April 27, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants