refactor metrics defaultCollector&&agg #12206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto default-refactor
|
@AlbumenJ @songxiaosheng PTAL |
Codecov Report
@@ Coverage Diff @@
## 3.2 #12206 +/- ##
============================================
+ Coverage 68.91% 69.59% +0.68%
+ Complexity 341 2 -339
============================================
Files 3547 1598 -1949
Lines 162887 65629 -97258
Branches 26891 9573 -17318
============================================
- Hits 112247 45674 -66573
+ Misses 40855 15548 -25307
+ Partials 9785 4407 -5378 see 2017 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
songxiaosheng
approved these changes
Apr 29, 2023
Comment on lines
+88
to
+106
| public static MetricsKey getMetricsKey(RpcException e) { | ||
| MetricsKey targetKey; | ||
| targetKey = MetricsKey.METRIC_REQUESTS_FAILED; | ||
| if (e.isTimeout()) { | ||
| targetKey = MetricsKey.METRIC_REQUESTS_TIMEOUT; | ||
| } | ||
| if (e.isLimitExceed()) { | ||
| targetKey = MetricsKey.METRIC_REQUESTS_LIMIT; | ||
| } | ||
| if (e.isBiz()) { | ||
| targetKey = MetricsKey.METRIC_REQUEST_BUSINESS_FAILED; | ||
| } | ||
| if (e.isSerialization()) { | ||
| targetKey = MetricsKey.METRIC_REQUESTS_CODEC_FAILED; | ||
| } | ||
| if (e.isNetwork()) { | ||
| targetKey = MetricsKey.METRIC_REQUESTS_NETWORK_FAILED; | ||
| } | ||
| return targetKey; |
There was a problem hiding this comment.
in the future we also cloud use map to store the relation exception to metric key
AlbumenJ
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Use the same API as the three centers
link #11941