Metrics opt #12288
Merged
Metrics opt #12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
approved these changes
May 11, 2023
|
@songxiaosheng PTAL |
…o into opt_stats_app_level
…o into opt_stats_app_level
|
please fix ci problem |
done |
Codecov Report
@@ Coverage Diff @@
## 3.2 #12288 +/- ##
============================================
+ Coverage 68.62% 69.33% +0.70%
+ Complexity 114 2 -112
============================================
Files 3565 1607 -1958
Lines 164663 66250 -98413
Branches 27092 9717 -17375
============================================
- Hits 113008 45934 -67074
+ Misses 41722 15864 -25858
+ Partials 9933 4452 -5481 see 2005 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A series of optimizations for the metrics code，make code more reusable and more streamlined
Brief changelog
1、When exporting metrics, application information is optimized from parameter passing to construction injection.
2、Use AbstractMetricsExport to store the public ApplicationModel of each type of Export.
3、Optimize ApplicationStatComposite, because StatComposite belongs to APP level, simplify Map<MetricsKey, Map<String, AtomicLong>> data structure to Map<MetricsKey, AtomicLong>
4、Add an inheritance relationship to the subclass of Metric（ApplicationMetric、ServiceKeyMetric、MethodMetric）, so that it is more in line with the relationship between objects and improves code reusability
5、MetricsKey tag adds module id to prevent app conflicts