Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix prometheus init failed when start #12349

Merged
merged 5 commits into from
May 19, 2023

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

fix #12321 when simpleclient_pushgateway don't exists cause start failed

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@songxiaosheng songxiaosheng mentioned this pull request May 19, 2023
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.8% 68.8% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12349 (d713341) into 3.2 (35fdf9d) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12349      +/-   ##
============================================
- Coverage     69.68%   69.34%   -0.35%     
+ Complexity      339        2     -337     
============================================
  Files          1828     1607     -221     
  Lines         95300    66267   -29033     
  Branches      17344     9722    -7622     
============================================
- Hits          66407    45950   -20457     
+ Misses        23442    15858    -7584     
+ Partials       5451     4459     -992     

see 3435 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit c22db81 into apache:3.2 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dubbo3.2.0启动报错
3 participants