Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PortUnification+encodeInIOThread=false cause server response emp… #12355

Merged
merged 1 commit into from
May 20, 2023
+6 −1
Merged

fix: PortUnification+encodeInIOThread=false cause server response emp… #12355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...emoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ final class NettyChannel extends AbstractChannel {

private final Netty4BatchWriteQueue writeQueue;

private final Codec2 codec;
private Codec2 codec;

private final boolean encodeInIOThread;

Expand Down Expand Up @@ -365,4 +365,8 @@ private static Codec2 getChannelCodec(URL url) {
return frameworkModel.getExtensionLoader(Codec2.class).getExtension("default");
}
}

public void setCodec(Codec2 codec) {
this.codec = codec;
}
}
1 change: 1 addition & 0 deletions ...-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConfigOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public void configChannelHandler(List<ChannelHandler> handlerList) {
}

if (!(codec2 instanceof DefaultCodec)){
((NettyChannel) channel).setCodec(codec2);
NettyCodecAdapter codec = new NettyCodecAdapter(codec2, channel.getUrl(), handler);
((NettyChannel) channel).getNioChannel().pipeline().addLast(
codec.getDecoder()
Expand Down