-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialization RpcException bug pr rebase #12357
Conversation
Please fix uts |
How about change it to judge IOException? Let's standardize all exceptions thrown under Serialzation into IOException, and then unify catch IOException to judge whether it is serialization. In otherwise, such transform will discard some real network exception. |
Codecov Report
@@ Coverage Diff @@
## 3.2 #12357 +/- ##
============================================
+ Coverage 68.68% 69.28% +0.59%
+ Complexity 341 2 -339
============================================
Files 3569 1615 -1954
Lines 164820 66670 -98150
Branches 27335 9761 -17574
============================================
- Hits 113204 46189 -67015
+ Misses 41681 16021 -25660
+ Partials 9935 4460 -5475 see 2031 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PTAL again |
...pi/src/main/java/org/apache/dubbo/common/serialize/DefaultSerializationExceptionWrapper.java
Outdated
Show resolved
Hide resolved
…apache/dubbo/common/serialize/DefaultSerializationExceptionWrapper.java Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
...ubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedExchangeCodec.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
rebase #12280 because of merged by branch 2.7