add metrics enable switch #12389
Merged
add metrics enable switch #12389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
requested changes
May 23, 2023
...trics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/filter/MetricsFilter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 3.2 #12389 +/- ##
============================================
- Coverage 69.50% 69.36% -0.15%
+ Complexity 339 2 -337
============================================
Files 3466 1623 -1843
Lines 163719 67001 -96718
Branches 27453 9817 -17636
============================================
- Hits 113799 46475 -67324
+ Misses 39937 16028 -23909
+ Partials 9983 4498 -5485 see 1876 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
songxiaosheng
requested changes
May 24, 2023
songxiaosheng
requested changes
May 26, 2023
...trics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/filter/MetricsFilter.java
Outdated
Show resolved
Hide resolved
AlbumenJ
requested changes
Jun 2, 2023
| @@ -1002,7 +1002,7 @@ void testMetaData() throws Exception { | |||
| List<Class<? extends AbstractConfig>> configClasses = Arrays.asList(ApplicationConfig.class, | |||
| ConsumerConfig.class, ProviderConfig.class, ReferenceConfig.class, ServiceConfig.class, | |||
| ProtocolConfig.class, RegistryConfig.class, ConfigCenterConfig.class, MetadataReportConfig.class, | |||
| ModuleConfig.class, SslConfig.class, MetricsConfig.class, MonitorConfig.class, MethodConfig.class); | |||
| ModuleConfig.class, SslConfig.class, MonitorConfig.class, MethodConfig.class); | |||
There was a problem hiding this comment.
Because the property enableRpc of MetricsConfig is set to true, the metadata won't be empty
There was a problem hiding this comment.
Is there any problem if set null as default?
AlbumenJ
approved these changes
Jun 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If user use custom metrics component, we need support switch for default MetricsFilter.
The default value of enabled is true.
Brief changelog
Verifying this change
Checklist