Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple set resolve fallback enable as default #12575

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 20, 2023

What is the purpose of the change

  1. Add addIfAbsent to prevent service with version to override service without version
  2. Add logs
  3. Set RESOLVE_FALLBACK_TO_DEFAULT as true by default

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member Author

@guohao @EarthChen PTAL

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.2@3b7934f). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.2   #12575   +/-   ##
======================================
  Coverage       ?   69.39%           
  Complexity     ?        2           
======================================
  Files          ?     1627           
  Lines          ?    67346           
  Branches       ?     9876           
======================================
  Hits           ?    46736           
  Misses         ?    16105           
  Partials       ?     4505           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

54.5% 54.5% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 9577d46 into apache:3.2 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants