Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add framework metrics #12576

Merged

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@songxiaosheng songxiaosheng added the status/don’t-merge No plan to merge label Jun 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.2% 74.2% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12576 (6f97f83) into 3.2 (ea35f7e) will decrease coverage by 0.63%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12576      +/-   ##
============================================
- Coverage     69.95%   69.33%   -0.63%     
+ Complexity      339        2     -337     
============================================
  Files          1847     1629     -218     
  Lines         97492    67344   -30148     
  Branches      17846     9879    -7967     
============================================
- Hits          68205    46696   -21509     
+ Misses        23828    16133    -7695     
+ Partials       5459     4515     -944     

see 3476 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj changed the base branch from 3.2 to 3.3 June 28, 2023 07:42
@AlbumenJ AlbumenJ merged commit 1c65617 into apache:3.3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/don’t-merge No plan to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants